apm-server icon indicating copy to clipboard operation
apm-server copied to clipboard

test: add cpuprofile arg support to benchmark make task

Open kruskall opened this issue 2 years ago • 2 comments

Motivation/summary

Add BENCHMARK_CPU_OUT variable and pass cpuprofile arg to apmbench.

This PR allows creating cpu profile when running benchmark to investigate performance issues.

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

  1. BENCHMARK_CPU_OUT=cpu.out make run-benchmark
  2. BENCHMARK_CPU_OUT=cpu.out make cp-cpuprof
  3. open cpu.out file locally

Related issues

kruskall avatar Nov 17 '23 20:11 kruskall

This pull request does not have a backport label. Could you fix it @kruskall? 🙏 To fixup this pull request, you need to add the backport labels for the needed branches, such as:

  • backport-7.17 is the label to automatically backport to the 7.17 branch.
  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.

NOTE: backport-skip has been added to this pull request.

mergify[bot] avatar Nov 17 '23 20:11 mergify[bot]

run docs-build

v1v avatar Feb 09 '24 08:02 v1v