apm-agent-python icon indicating copy to clipboard operation
apm-agent-python copied to clipboard

metrics.base_metrics.Counter API

Open axw opened this issue 6 years ago • 0 comments

Is Counter meant to guarantee monotonically increasing values? It doesn't at the moment, since there's both a dec method and an inc method that accepts negative values.

What's the reason behind not providing a direct value setter? Even if we require the value to be monotonically increasing, you could for example check the current value and raise an exception if the new value is less. If there were a setter, then the GarbageMetrics.collect method in https://github.com/elastic/apm-agent-python/pull/481 could be simplified.

axw avatar Jun 11 '19 08:06 axw