apm-agent-python
apm-agent-python copied to clipboard
[Azure Tables] Check if request body exists before trying to convert it to JSON
What does this pull request do?
Checks existence of body payload in request to Azure Table service before trying to convert it into JSON, thus avoiding TypeError
Related issues
Closes #2118
Hi @xrmx , I'm developing the tests, but I have realized that the problem is that I'm using the new Python library for Azure Tables (package azure-data-tables) but the tests are done using the deprecated library (azure-cosmosdb-tables package). The deprecation warning is in the new package documentation: azure-data-tables
Should I keep tests for both libraries in tests/instrumentation/azure_tests.py? Or should I just remove the code that refers to azure-cosmosdb-tables?
Hi @xrmx , I'm developing the tests, but I have realized that the problem is that I'm using the new Python library for Azure Tables (package
azure-data-tables) but the tests are done using the deprecated library (azure-cosmosdb-tablespackage). The deprecation warning is in the new package documentation: azure-data-tables
Interesting
Should I keep tests for both libraries in
tests/instrumentation/azure_tests.py? Or should I just remove the code that refers toazure-cosmosdb-tables?
tests for cosmosdb need to be kept
Hi @xrmx, I have just pushed the requested changes. Thanks for your help
Hi @xrmx, have you had time to review the changes? I'm thinking maybe the PR should be renamed to "Support for azure-data-tables", what do you think?
Thanks for your help.
Hi @xrmx, do you need anything else by my side? Is there any way I can help to make this change to be reviewed and (hopefully) merged?
Any updates on this?