apm-agent-python icon indicating copy to clipboard operation
apm-agent-python copied to clipboard

feat: add typing on some public api functions

Open pbabics opened this issue 1 year ago • 4 comments

What does this pull request do?

  • Adds typing on some of the publicly exposed API functions
  • Explicitly export API in __init__.py

pbabics avatar Mar 06 '24 16:03 pbabics

💚 CLA has been signed

Thanks for the PR. We should probably add some mypy run in CI to check we are not messing up anything.

xrmx avatar Mar 06 '24 16:03 xrmx

Hello, I've checked mypy output and there is a lot of errors because most of the code either does not have typing or has wrong/incomplete typing

pbabics avatar Mar 07 '24 08:03 pbabics

Hello, I've checked mypy output and there is a lot of errors because most of the code either does not have typing or has wrong/incomplete typing

Right, maybe we can think of an incremental strategy for typing. Let me think about it a bit.

xrmx avatar Mar 08 '24 09:03 xrmx