apm-agent-python icon indicating copy to clipboard operation
apm-agent-python copied to clipboard

[META 672] Add option for when to capture the Elasticsearch query

Open elastic-apm-tech opened this issue 2 years ago • 2 comments

See meta issue and spec for the description and details:

  • Meta issue: https://github.com/elastic/apm/issues/672
  • Spec issue: https://github.com/elastic/apm/issues/673

elastic-apm-tech avatar Aug 16 '22 11:08 elastic-apm-tech

Should just be a change to the default behavior, since we don't plan to add the new config value to the python agent.

basepi avatar Aug 16 '22 15:08 basepi

This is what the spec says:

Agents MAY offer this configuration option. If they don't, they MUST use a hard-coded list of URLs that correspond with the default value of this option.

So it's fine if you don't want to expose a config option, but the default behavior must be aligned (with the exact same wildcard matchers). At that point, exposing the config option is probably also not more work.

felixbarny avatar Aug 16 '22 15:08 felixbarny