apm-agent-python icon indicating copy to clipboard operation
apm-agent-python copied to clipboard

Add body length check for Django's capture_body

Open basepi opened this issue 3 years ago • 2 comments

What does this pull request do?

We had no restrictions on the body length in Django. This could result in the event payload being rejected by the APM Server.

As an aside, we'll need to figure out a better solution in the long term. (#305)

Related issues

closes #1478

basepi avatar Aug 11 '22 19:08 basepi

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-15T18:13:30.459+0000

  • Duration: 31 min 2 sec

Test stats :test_tube:

Test Results
Failed 0
Passed 4969
Skipped 3420
Total 8389

:green_heart: Flaky test report

Tests succeeded.

:robot: GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

apmmachine avatar Aug 11 '22 20:08 apmmachine

:globe_with_meridians: Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (68/68) :green_heart:
Files 100.0% (227/227) :green_heart:
Classes 100.0% (227/227) :green_heart:
Lines 89.751% (17444/19436) :+1: 0.008
Conditionals 77.18% (3186/4128) :+1: 0.022

apmmachine avatar Aug 11 '22 20:08 apmmachine

/test

basepi avatar Aug 15 '22 18:08 basepi