apm-agent-python icon indicating copy to clipboard operation
apm-agent-python copied to clipboard
verified publisher icon elastic

Clarify ASGI support

Open thenewguy opened this issue 4 years ago • 1 comments

There is conflicting documentation around supporting ASGI.

For example, https://github.com/elastic/apm-agent-python/blob/63fbeb971e40bf3d967b345e4217085335d28b5b/CHANGELOG.asciidoc#bug-fixes-6 and https://github.com/elastic/apm-agent-python/blob/c04c634aca50cffdb6b6c174a30629b0749193cb/docs/supported-technologies.asciidoc#django

The ASGI issues with Django appear to be resolved https://github.com/elastic/apm-agent-python/search?q=asgi&type=issues

thenewguy avatar Feb 16 '21 22:02 thenewguy

@thenewguy great find!

One thing I'd like to clarify before we declare that we're actually supporting ASGI is if the agent works correctly with async views. I'm not sure if we'll track the execution context correctly across async-to-sync boundaries (e.g. when doing ORM queries in an async view).

beniwohli avatar Feb 18 '21 09:02 beniwohli