apm-agent-php icon indicating copy to clipboard operation
apm-agent-php copied to clipboard

Feature/add mysqli auto instrument

Open bck01215 opened this issue 2 years ago • 9 comments

This should solve #575, #596, and #639. This could probably use some cleaning up, but it worked when I tested it, and it gathered the latency of mysqli requests. I'm sure there is a way to get more useful information out of it, but, since I know little to nothing about PHP, I was unable to figure out some of the features. Please suggest alterations and corrections as needed.

bck01215 avatar May 23 '22 17:05 bck01215

💚 CLA has been signed

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-22T07:55:09.204+0000

  • Duration: 21 min 21 sec

Test stats :test_tube:

Test Results
Failed 0
Passed 16359
Skipped 0
Total 16359

:green_heart: Flaky test report

Tests succeeded.

:robot: GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

apmmachine avatar May 23 '22 17:05 apmmachine

/test

SergeyKleyman avatar May 30 '22 10:05 SergeyKleyman

@bck01215 Thank you very much for the contribution. I'll review it ASAP. In the meantime could you please sign up the Contributor Agreement?

SergeyKleyman avatar May 30 '22 10:05 SergeyKleyman

@bck01215 Thank you very much for the contribution. I'll review it ASAP. In the meantime could you please sign up the Contributor Agreement? I had to fix the author of the previous commits. It should be good now

bck01215 avatar May 30 '22 19:05 bck01215

/test

bck01215 avatar May 30 '22 20:05 bck01215

/test

SergeyKleyman avatar Jun 01 '22 07:06 SergeyKleyman

@bck01215 Hi. Thank you very much for contributing. Would you mind if I merge fixes to failing build directly into your PR?

SergeyKleyman avatar Jun 13 '22 20:06 SergeyKleyman

@bck01215 Hi. Thank you very much for contributing. Would you mind if I merge fixes to failing build directly into your PR?

Please do.

bck01215 avatar Jun 13 '22 21:06 bck01215

/test

SergeyKleyman avatar Sep 22 '22 07:09 SergeyKleyman

run elasticsearch-ci/docs

SergeyKleyman avatar Sep 22 '22 09:09 SergeyKleyman