apm-agent-php icon indicating copy to clipboard operation
apm-agent-php copied to clipboard

WordPress AutoInstrument: Skip WP Core

Open xyu opened this issue 1 year ago • 1 comments

With the current WordPress auto-instrumentation implementation most of the spans in APM traces are filled with WP core functions.

For the most part this is not super useful for the majority of WordPress developers / users because there's not much they can do to change how core works. It's also relatively unlikely performance issues are caused by WP core functions as they are used by all WP users and have over the decades been optimized and looked at closely.

It's much more likely performance issues arise due to the themes or plugins that are installed on a site. So it would be more useful to only expose WordPress theme and plugin callbacks as span by default. These callbacks are how WP developers normally go about modifying and adding functionality. (No "core hacks" has been a core tenet of WP developers for quite a long time now.)

This PR makes it so that we default skip instrumentation of WP core callbacks unless a WP_DEBUG constant is set which is the WP convention for turning on more verbose logging: https://wordpress.org/documentation/article/debugging-in-wordpress/

xyu avatar Jul 24 '23 16:07 xyu

run docs-build

v1v avatar Feb 09 '24 08:02 v1v