apm-agent-nodejs icon indicating copy to clipboard operation
apm-agent-nodejs copied to clipboard

fix: capture route from base on express app.use

Open isikhi opened this issue 2 years ago • 4 comments

Closes: #3630

The error mentioned in the issue has been corrected.

Checklist

  • [x] Implement code
  • [x] Add tests
  • [ ] Update TypeScript typings
  • [ ] Update documentation
  • [x] Add CHANGELOG.asciidoc entry
  • [x] Commit message follows commit guidelines

isikhi avatar Sep 20 '23 14:09 isikhi

❌ Author of the following commits did not sign a Contributor Agreement: c8cf0b9201f05eb7cbd3f7516967023d19f22157,

Please, read and sign the above mentioned agreement if you want to contribute to this project

I signed CLA after the merge request opened, is there any problem with CLA synchronization?

isikhi avatar Sep 20 '23 14:09 isikhi

I signed CLA a few times but could not completed this step idk why. I signed with github related email but i am not sure why it is not completed :thinking: Any help ? Or maybe you can cherry pick my changes these are a few little changes.

isikhi avatar Nov 21 '23 15:11 isikhi

Hi @isikhi

about the CLA you may want to send an email to [email protected]

also I want to ask if you checked my last comment on #3630. The sample you provided has the require('express') before the require('elastic-apm-node').start(...)so that agent is too late to instrument the express framework.

Please confirm you have tested your sample with require('elastic-apm-node').start(...) at the top of the file and see the same behavior. Thanks!

david-luna avatar Nov 30 '23 11:11 david-luna