apm-agent-nodejs icon indicating copy to clipboard operation
apm-agent-nodejs copied to clipboard

Published 20 hours ago • verified publisher icon elastic

refactor!: drop support for Node 8

Open watson opened this issue 5 years ago • 2 comments
trafficstars

Due to how quickly the community is dropping support for Node.js 8, it gets harder and harder for us to maintain support for it. So let's get ready to release version 4.0.0 of the agent with removed support for Node.js 8.

Note however that we'll still have to support it in the 3.x branch for the sake of security/bug fixes, but this also means that we can stop backporting to the 2.x branch which means no longer having to deal with Node.js 6 😅

watson avatar Mar 05 '20 14:03 watson

jenkins run the module tests for ALL

watson avatar Mar 05 '20 14:03 watson

:broken_heart: Build Failed

Pipeline View Test View Changes Artifacts preview stats

Expand to view the summary

Build stats

  • Build Cause: [Branch indexing]

  • Start Time: 2020-05-07T18:21:15.932+0000

  • Duration: 23 min 23 sec (1403357)

  • Commit: 09abdd9076033311c162f7e19b7fdc2abc5d471d

Test stats :test_tube:

Test Results
Failed 0
Passed 100492
Skipped 0
Total 100492

Steps errors

Expand to view the steps failures

  • Name: Run Tests

    • Description:

    • Result: FAILURE

    • Duration: 7 min 24 sec<

    • Start Time: 2020-05-07T18:30:13.357+0000

  • Name: Run Tests

    • Description:

    • Result: FAILURE

    • Duration: 5 min 1 sec<

    • Start Time: 2020-05-07T18:37:47.042+0000

  • Name: Error signal

    • Description: hudson.AbortException: script returned exit code 1

    • Result: FAILURE

    • Duration: 0 min 0 sec<

    • Start Time: 2020-05-07T18:42:48.061+0000

  • Name: Run Tests

    • Description:

    • Result: FAILURE

    • Duration: 7 min 53 sec<

    • Start Time: 2020-05-07T18:30:23.037+0000

  • Name: Run Tests

    • Description:

    • Result: FAILURE

    • Duration: 5 min 1 sec<

    • Start Time: 2020-05-07T18:37:29.885+0000

  • Name: Error signal

    • Description: hudson.AbortException: script returned exit code 1

    • Result: FAILURE

    • Duration: 0 min 0 sec<

    • Start Time: 2020-05-07T18:42:30.845+0000

  • Name: Run Tests

    • Description:

    • Result: FAILURE

    • Duration: 8 min 34 sec<

    • Start Time: 2020-05-07T18:30:26.306+0000

  • Name: Run Tests

    • Description:

    • Result: FAILURE

    • Duration: 5 min 57 sec<

    • Start Time: 2020-05-07T18:38:08.343+0000

  • Name: Error signal

    • Description: hudson.AbortException: script returned exit code 1

    • Result: FAILURE

    • Duration: 0 min 0 sec<

    • Start Time: 2020-05-07T18:43:05.756+0000

  • Name: Run Tests

    • Description:

    • Result: FAILURE

    • Duration: 7 min 23 sec<

    • Start Time: 2020-05-07T18:30:34.704+0000

  • Name: Run Tests

    • Description:

    • Result: FAILURE

    • Duration: 5 min 56 sec<

    • Start Time: 2020-05-07T18:38:05.497+0000

  • Name: Error signal

    • Description: hudson.AbortException: script returned exit code 1

    • Result: FAILURE

    • Duration: 0 min 0 sec<

    • Start Time: 2020-05-07T18:43:05.652+0000

  • Name: Run Tests

    • Description:

    • Result: FAILURE

    • Duration: 6 min 44 sec<

    • Start Time: 2020-05-07T18:30:36.026+0000

  • Name: Run Tests

    • Description:

    • Result: FAILURE

    • Duration: 5 min 51 sec<

    • Start Time: 2020-05-07T18:36:33.064+0000

  • Name: Error signal

    • Description: hudson.AbortException: script returned exit code 1

    • Result: FAILURE

    • Duration: 0 min 0 sec<

    • Start Time: 2020-05-07T18:41:24.268+0000

  • Name: Run Tests

    • Description:

    • Result: FAILURE

    • Duration: 8 min 35 sec<

    • Start Time: 2020-05-07T18:30:34.461+0000

  • Name: Run Tests

    • Description:

    • Result: FAILURE

    • Duration: 5 min 9 sec<

    • Start Time: 2020-05-07T18:38:19.825+0000

  • Name: Error signal

    • Description: hudson.AbortException: script returned exit code 1

    • Result: FAILURE

    • Duration: 0 min 0 sec<

    • Start Time: 2020-05-07T18:43:29.303+0000

  • Name: Run Tests

    • Description:

    • Result: FAILURE

    • Duration: 7 min 50 sec<

    • Start Time: 2020-05-07T18:30:34.275+0000

  • Name: Run Tests

    • Description:

    • Result: FAILURE

    • Duration: 5 min 51 sec<

    • Start Time: 2020-05-07T18:37:34.235+0000

  • Name: Error signal

    • Description: hudson.AbortException: script returned exit code 1

    • Result: FAILURE

    • Duration: 0 min 0 sec<

    • Start Time: 2020-05-07T18:42:25.482+0000

  • Name: Run Tests

    • Description:

    • Result: FAILURE

    • Duration: 8 min 35 sec<

    • Start Time: 2020-05-07T18:30:34.999+0000

  • Name: Run Tests

    • Description:

    • Result: FAILURE

    • Duration: 5 min 5 sec<

    • Start Time: 2020-05-07T18:38:15.594+0000

  • Name: Error signal

    • Description: hudson.AbortException: script returned exit code 1

    • Result: FAILURE

    • Duration: 0 min 0 sec<

    • Start Time: 2020-05-07T18:43:20.976+0000

  • Name: Run Tests

    • Description:

    • Result: FAILURE

    • Duration: 7 min 33 sec<

    • Start Time: 2020-05-07T18:30:40.377+0000

  • Name: Run Tests

    • Description:

    • Result: FAILURE

    • Duration: 5 min 9 sec<

    • Start Time: 2020-05-07T18:37:25.132+0000

  • Name: Error signal

    • Description: hudson.AbortException: script returned exit code 1

    • Result: FAILURE

    • Duration: 0 min 0 sec<

    • Start Time: 2020-05-07T18:42:34.355+0000

  • Name: Run Tests

    • Description:

    • Result: FAILURE

    • Duration: 7 min 17 sec<

    • Start Time: 2020-05-07T18:30:41.439+0000

  • Name: Run Tests

    • Description:

    • Result: FAILURE

    • Duration: 5 min 59 sec<

    • Start Time: 2020-05-07T18:38:12.637+0000

  • Name: Error signal

    • Description: hudson.AbortException: script returned exit code 1

    • Result: FAILURE

    • Duration: 0 min 0 sec<

    • Start Time: 2020-05-07T18:43:11.465+0000

  • Name: Run Tests

    • Description:

    • Result: FAILURE

    • Duration: 7 min 28 sec<

    • Start Time: 2020-05-07T18:30:57.767+0000

  • Name: Run Tests

    • Description:

    • Result: FAILURE

    • Duration: 5 min 55 sec<

    • Start Time: 2020-05-07T18:38:34.497+0000

  • Name: Error signal

    • Description: hudson.AbortException: script returned exit code 1

    • Result: FAILURE

    • Duration: 0 min 0 sec<

    • Start Time: 2020-05-07T18:43:29.307+0000

  • Name: Run Tests

    • Description:

    • Result: FAILURE

    • Duration: 8 min 17 sec<

    • Start Time: 2020-05-07T18:26:19.129+0000

  • Name: Run Tests

    • Description:

    • Result: FAILURE

    • Duration: 5 min 14 sec<

    • Start Time: 2020-05-07T18:34:42.746+0000

  • Name: Error signal

    • Description: hudson.AbortException: script returned exit code 1

    • Result: FAILURE

    • Duration: 0 min 0 sec<

    • Start Time: 2020-05-07T18:39:57.159+0000

Log output

Expand to view the last 100 lines of log output 

[2020-05-07T18:44:26.429Z] ok 7 top frame should be this file
[2020-05-07T18:44:26.429Z] 
[2020-05-07T18:44:26.429Z] 1..7
[2020-05-07T18:44:26.429Z] # tests 7
[2020-05-07T18:44:26.429Z] # pass  7
[2020-05-07T18:44:26.429Z] 
[2020-05-07T18:44:26.429Z] # ok
[2020-05-07T18:44:26.429Z] 
[2020-05-07T18:44:26.429Z] running (cwd: ./): node --unhandled-rejections=strict test\uncaught-exceptions\log-uncaught-exceptions-on.js
[2020-05-07T18:44:27.004Z] TAP version 13
[2020-05-07T18:44:27.004Z] # should capture and log uncaught exceptions by default
[2020-05-07T18:44:27.004Z] ok 1 should log the error to STDERR
[2020-05-07T18:44:27.004Z] Error: foo
[2020-05-07T18:44:27.004Z]     at Test.<anonymous> (C:\Users\jenkins\workspace\ejs_apm-agent-nodejs-mbp_PR-1666\src\github.com\elastic\apm-agent-nodejs\test\uncaught-exceptions\log-uncaught-exceptions-on.js:43:23)
[2020-05-07T18:44:27.004Z]     at Test.bound [as _cb] (C:\Users\jenkins\workspace\ejs_apm-agent-nodejs-mbp_PR-1666\src\github.com\elastic\apm-agent-nodejs\node_modules\tape\lib\test.js:80:32)
[2020-05-07T18:44:27.004Z]     at Test.run (C:\Users\jenkins\workspace\ejs_apm-agent-nodejs-mbp_PR-1666\src\github.com\elastic\apm-agent-nodejs\node_modules\tape\lib\test.js:96:10)
[2020-05-07T18:44:27.004Z]     at Test.bound [as run] (C:\Users\jenkins\workspace\ejs_apm-agent-nodejs-mbp_PR-1666\src\github.com\elastic\apm-agent-nodejs\node_modules\tape\lib\test.js:80:32)
[2020-05-07T18:44:27.004Z]     at Immediate.next (C:\Users\jenkins\workspace\ejs_apm-agent-nodejs-mbp_PR-1666\src\github.com\elastic\apm-agent-nodejs\node_modules\tape\lib\results.js:81:19)
[2020-05-07T18:44:27.004Z]     at Immediate.elasticAPMCallbackWrapper (C:\Users\jenkins\workspace\ejs_apm-agent-nodejs-mbp_PR-1666\src\github.com\elastic\apm-agent-nodejs\lib\instrumentation\index.js:309:27)
[2020-05-07T18:44:27.004Z]     at processImmediate (internal/timers.js:456:21)
[2020-05-07T18:44:27.004Z] ok 2 should capture the error
[2020-05-07T18:44:27.004Z] Sending error to Elastic APM { id: 'c811f3ccbd7ed97895ac0565ca88eaba' }
[2020-05-07T18:44:27.004Z] ok 3 should be equal
[2020-05-07T18:44:27.004Z] ok 4 should be equal
[2020-05-07T18:44:27.004Z] ok 5 should be equal
[2020-05-07T18:44:27.004Z] ok 6 should have a stack trace
[2020-05-07T18:44:27.005Z] ok 7 stack trace should contain frames
[2020-05-07T18:44:27.005Z] ok 8 top frame should be this file
[2020-05-07T18:44:27.005Z] 
[2020-05-07T18:44:27.005Z] 1..8
[2020-05-07T18:44:27.005Z] # tests 8
[2020-05-07T18:44:27.005Z] # pass  8
[2020-05-07T18:44:27.005Z] 
[2020-05-07T18:44:27.005Z] # ok
[2020-05-07T18:44:27.005Z] 
[2020-05-07T18:44:27.305Z] JUnit archiving no yet in place
[2020-05-07T18:44:27.720Z] + .ci/scripts/windows/stop-test.sh 12
[2020-05-07T18:44:27.720Z] + NODE_VERSION=12
[2020-05-07T18:44:27.720Z] + NODE_VERSION=12
[2020-05-07T18:44:27.720Z] + docker-compose --no-ansi -f .ci/docker/docker-compose-all.yml logs --timestamps
[2020-05-07T18:44:28.691Z] The TAV_VERSIONS variable is not set. Defaulting to a blank string.
[2020-05-07T18:44:28.691Z] The ELASTIC_APM_ASYNC_HOOKS variable is not set. Defaulting to a blank string.
[2020-05-07T18:44:28.691Z] The USER_ID variable is not set. Defaulting to a blank string.
[2020-05-07T18:44:32.122Z] + NODE_VERSION=12
[2020-05-07T18:44:32.122Z] + docker-compose --no-ansi --log-level ERROR -f .ci/docker/docker-compose-all.yml down -v
[2020-05-07T18:44:32.404Z] Stopping docker_postgres_1      ... 
[2020-05-07T18:44:32.404Z] Stopping docker_mongodb_1       ... 
[2020-05-07T18:44:32.404Z] Stopping docker_mysql_1         ... 
[2020-05-07T18:44:32.404Z] Stopping docker_memcached_1     ... 
[2020-05-07T18:44:32.404Z] Stopping docker_elasticsearch_1 ... 
[2020-05-07T18:44:32.404Z] Stopping docker_cassandra_1     ... 
[2020-05-07T18:44:32.404Z] Stopping docker_redis_1         ... 
[2020-05-07T18:44:32.404Z] Stopping docker_mssql_1         ... 
[2020-05-07T18:44:33.369Z] Stopping docker_mongodb_1       ... done
[2020-05-07T18:44:33.369Z] Stopping docker_memcached_1     ... done
[2020-05-07T18:44:33.369Z] Stopping docker_redis_1         ... done
[2020-05-07T18:44:33.369Z] Stopping docker_postgres_1      ... done
[2020-05-07T18:44:33.631Z] Stopping docker_elasticsearch_1 ... done
[2020-05-07T18:44:34.211Z] Stopping docker_mysql_1         ... done
[2020-05-07T18:44:34.473Z] Stopping docker_mssql_1         ... done
[2020-05-07T18:44:35.423Z] Stopping docker_cassandra_1     ... done
[2020-05-07T18:44:35.423Z] Removing docker_node_tests_1    ... 
[2020-05-07T18:44:35.423Z] Removing docker_postgres_1      ... 
[2020-05-07T18:44:35.423Z] Removing docker_mongodb_1       ... 
[2020-05-07T18:44:35.423Z] Removing docker_mysql_1         ... 
[2020-05-07T18:44:35.423Z] Removing docker_memcached_1     ... 
[2020-05-07T18:44:35.423Z] Removing docker_elasticsearch_1 ... 
[2020-05-07T18:44:35.423Z] Removing docker_cassandra_1     ... 
[2020-05-07T18:44:35.423Z] Removing docker_redis_1         ... 
[2020-05-07T18:44:35.423Z] Removing docker_mssql_1         ... 
[2020-05-07T18:44:35.423Z] Removing docker_elasticsearch_1 ... done
[2020-05-07T18:44:35.423Z] Removing docker_mysql_1         ... done
[2020-05-07T18:44:35.423Z] Removing docker_mongodb_1       ... done
[2020-05-07T18:44:35.423Z] Removing docker_memcached_1     ... done
[2020-05-07T18:44:35.687Z] Removing docker_postgres_1      ... done
[2020-05-07T18:44:35.687Z] Removing docker_cassandra_1     ... done
[2020-05-07T18:44:35.687Z] Removing docker_mssql_1         ... done
[2020-05-07T18:44:35.687Z] Removing docker_redis_1         ... done
[2020-05-07T18:44:36.265Z] Removing docker_node_tests_1    ... done
[2020-05-07T18:44:37.879Z] Stage "TAV Test" skipped due to earlier failure(s)
[2020-05-07T18:44:37.942Z] Stage "Edge Test" skipped due to earlier failure(s)
[2020-05-07T18:44:38.011Z] Stage "Nightly Test" skipped due to earlier failure(s)
[2020-05-07T18:44:38.017Z] Stage "Nightly Test - No async hooks" skipped due to earlier failure(s)
[2020-05-07T18:44:38.023Z] Stage "RC Test" skipped due to earlier failure(s)
[2020-05-07T18:44:38.029Z] Stage "RC Test - No async hooks" skipped due to earlier failure(s)
[2020-05-07T18:44:38.126Z] Failed in branch Nightly Test
[2020-05-07T18:44:38.133Z] Failed in branch Nightly Test - No async hooks
[2020-05-07T18:44:38.140Z] Failed in branch RC Test
[2020-05-07T18:44:38.148Z] Failed in branch RC Test - No async hooks
[2020-05-07T18:44:38.250Z] Stage "Integration Tests" skipped due to earlier failure(s)
[2020-05-07T18:44:38.313Z] Stage "Release" skipped due to earlier failure(s)
[2020-05-07T18:44:38.340Z] Stage "Release" skipped due to earlier failure(s)
[2020-05-07T18:44:38.441Z] Stage "Benchmarks" skipped due to earlier failure(s)
[2020-05-07T18:44:38.720Z] Running on Jenkins in /var/lib/jenkins/workspace/ejs_apm-agent-nodejs-mbp_PR-1666
[2020-05-07T18:44:38.774Z] [INFO] getVaultSecret: Getting secrets
[2020-05-07T18:44:38.852Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-05-07T18:44:39.559Z] + chmod 755 generate-build-data.sh
[2020-05-07T18:44:39.559Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/apm-agent-nodejs-mbp/PR-1666/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/apm-agent-nodejs-mbp/PR-1666/runs/14 FAILURE 1403357
[2020-05-07T18:44:40.110Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/apm-agent-nodejs-mbp/PR-1666/runs/14/steps/?limit=10000 -o steps-info.json
[2020-05-07T18:44:40.661Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-nodejs/apm-agent-nodejs-mbp/PR-1666/runs/14/tests/?status=FAILED -o tests-errors.json

apmmachine avatar May 04 '20 18:05 apmmachine

We will do this at some point, but given all the current conflicts, I think it'll be easier to start over.

trentm avatar Feb 01 '23 23:02 trentm