apm-agent-go
apm-agent-go copied to clipboard
feat: add 'service_target_*' fields to dropped spans metrics
Part of the implementation plan for span service target.
See https://github.com/elastic/apm/blob/main/specs/agents/tracing-spans-service-target.md
Closes https://github.com/elastic/apm-agent-go/issues/1291
:green_heart: Build Succeeded
the below badges are clickable and redirect to their specific view in the CI or DOCS
![]()
![]()
![]()
![]()
![]()
Expand to view the summary
Build stats
-
Start Time: 2022-09-14T11:04:36.851+0000
-
Duration: 60 min 43 sec
Test stats :test_tube:
Test | Results |
---|---|
Failed | 0 |
Passed | 8539 |
Skipped | 201 |
Total | 8740 |
:robot: GitHub comments
To re-run your PR in the CI, just comment with:
-
/test
: Re-trigger the build. -
run benchmark tests
: Run the benchmark test. -
run
elasticsearch-ci/docs
: Re-trigger the docs validation. (use unformatted text in the comment!)
:globe_with_meridians: Coverage report
Name | Metrics % (covered/total ) |
Diff |
---|---|---|
Packages | 100.0% (59/59 ) |
:green_heart: |
Files | 99.346% (152/153 ) |
:+1: |
Classes | 96.275% (336/349 ) |
:+1: |
Methods | 90.216% (959/1063 ) |
:+1: |
Lines | 82.229% (11179/13595 ) |
:+1: 0.115 |
Conditionals | 100.0% (0/0 ) |
:green_heart: |
@kruskall @axw is this blocked by anything or is the only part missing to add a test?
AFAICS this just needs a test.
I've updated the test!
Should we remove destination service resource from dropped spans ?