apm-agent-go icon indicating copy to clipboard operation
apm-agent-go copied to clipboard

implement OTel bridge

Open stuartnelson3 opened this issue 3 years ago • 5 comments

closes #1140

stuartnelson3 avatar Jan 28 '22 15:01 stuartnelson3

This is heavily annotated with TODO's and questions. Comments welcome!

stuartnelson3 avatar Jan 28 '22 15:01 stuartnelson3

:grey_exclamation: Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-07T17:20:36.308+0000

  • Duration: 3 min 50 sec

Steps errors 2

Expand to view the steps failures

Load a resource file from a library
  • Took 0 min 0 sec . View more details here
  • Description: approval-list/elastic/apm-agent-go.yml
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/stuartnelson3 return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/stuartnelson3 : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/stuartnelson3 : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}

:robot: GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

apmmachine avatar Jan 28 '22 15:01 apmmachine

still need to look into https://github.com/elastic/apm/blob/main/specs/agents/tracing-api-otel.md#compatibility-mapping, but i think this is ready for another review

stuartnelson3 avatar Mar 17 '22 17:03 stuartnelson3

@axw can we take a look at this next week? I implemented the wrapper methods for span and transaction like you mentioned to me, but I'm wondering if I'm misunderstanding something because I don't have all of the wrapper structs that you implement.

stuartnelson3 avatar Mar 18 '22 15:03 stuartnelson3

:globe_with_meridians: Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (59/59) :green_heart:
Files 99.346% (152/153) :+1:
Classes 96.812% (334/345) :+1: 0.558
Methods 90.746% (961/1059) :+1: 0.472
Lines 82.704% (11074/13390) :+1: 0.427
Conditionals 100.0% (0/0) :green_heart:

apmmachine avatar May 19 '22 17:05 apmmachine

Closing this for now as we are currently not working on this feature.

simitt avatar Sep 08 '22 06:09 simitt