apm-agent-dotnet
apm-agent-dotnet copied to clipboard
elastic
[FEATURE] About #1364 and #1374 Gone From the Redis Agent
While adding Redis Tracing for my company, I found out that the agent provided is not capturing the whole statement, but just the command was captured.
Then I looked up the issue on this GitHub. I found out that the feature was implemented in
#1374 Get Command and Key for StackExchange.Redis spans
which is intended for feature request
#1364 [FEATURE] Registering query parameters for 'StackExchange.Redis' spans
And from v1.11.0 to v1.22.0 the function still exists and can capture the whole statement.
However, starting from v1.23.0, which the instrument was moved to another folder, the method is gone.
Is it possible that we can add the feature back? Or is there other concerns that need to remove this feature?
### Tasks
I believe it's codebase synchronization issue. Is it possible to add back #1374 into the current release?
Writing this as a regression, previously you've added this part in https://github.com/elastic/apm-agent-dotnet/issues/1364 and now it's gone again. Why it was removed?
This is the place where it was removed: https://github.com/elastic/apm-agent-dotnet/pull/2104
Apologies for this. We will work on this to bring any lost features back.
As well to the same issue: we noticed that the previous working version didn't show the statement for SCAN, EVAL, EXEC commands (the statement is visible for GET, SET, SETEX). Why is that?
@grietine If those are new feature requests, would you mind opening a separate issue to request them? Let's keep this issue to the regression.
@grietine If those are new feature requests, would you mind opening a separate issue to request them? Let's keep this issue to the regression.
Sure, I've added a feature request: https://github.com/elastic/apm-agent-dotnet/issues/2352