apm-agent-dotnet icon indicating copy to clipboard operation
apm-agent-dotnet copied to clipboard

Change `TransactionInfo` and `SpanInfo` to `struct`

Open gregkalapos opened this issue 1 year ago • 0 comments

In Elastic.Apm.Metrics.TransactionInfo and Elastic.Apm.Metrics.SpanInfo are currently classes. In https://github.com/elastic/apm-agent-dotnet/pull/1816 we already made changed where we rely on value semantic. Additionally to that structs would be more efficient anyway.

We discussed this over zoom with @z1c0, outcome: since this would be a breaking change, let's wait with this until the next major version.

Discussion: https://github.com/elastic/apm-agent-dotnet/pull/1816#discussion_r971145227

gregkalapos avatar Sep 15 '22 16:09 gregkalapos