apm-agent-dotnet icon indicating copy to clipboard operation
apm-agent-dotnet copied to clipboard

#1779 Fixed container ID parsing in AWS ECS/Fargate environments

Open fruffin opened this issue 2 years ago • 2 comments

This fixes issue #1779 where container IDs can't be parsed in AWS ECS/Fargate environments

fruffin avatar Aug 10 '22 04:08 fruffin

💚 CLA has been signed

:green_heart: Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-29T11:21:16.167+0000

  • Duration: 78 min 37 sec

Test stats :test_tube:

Test Results
Failed 0
Passed 16503
Skipped 164
Total 16667

:robot: GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

apmmachine avatar Aug 10 '22 04:08 apmmachine

After upgrading my Elastic Cloud deployment to 8.4, I can confirm that the error I was seeing in Kibana is no longer occurring (#1779), but the change I made in this pull request is still required for it to work correctly. This is what it looks like with my fix in place: image

Please advise on the next steps, as I would rather not have to fork this repository to maintain this fix as we go to production with Elastic.

Thanks

fruffin avatar Aug 29 '22 03:08 fruffin

The build failed again due to the infrastructure (?) issue reported in #1799. I retriggered the build for now and will investigate the root cause at a later point.

z1c0 avatar Aug 29 '22 09:08 z1c0

LGTM 👍

(@fruffin can I ask to rebase your branch to main just to be sure.)

Done

fruffin avatar Aug 29 '22 12:08 fruffin

Thanks for this contribution @fruffin - that's highly appreciated! Your fix/PR will be included in the next release of apm-agent-dotnet(ETA not yet known).

z1c0 avatar Aug 29 '22 13:08 z1c0