apm-agent-dotnet icon indicating copy to clipboard operation
apm-agent-dotnet copied to clipboard

.net Agent support for outbound traffic using Proxy

Open m-hafi opened this issue 3 years ago • 3 comments

In this PR proxy support for outbound traffic is added to the HTTP Client Handler. This issue originated as our firm uses proxy for outbound traffic and the current .net Agent lacks this feature.

m-hafi avatar Feb 17 '22 14:02 m-hafi

❌ Author of the following commits did not sign a Contributor Agreement: 8f6f8274737f5aafc31900b211e92f12662b5cf3, c8f6280c67e360b0568fe6cfbe81b41e2ecbfddd

Please, read and sign the above mentioned agreement if you want to contribute to this project

:grey_exclamation: Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2022-05-12T17:52:45.979+0000

  • Duration: 3 min 7 sec

Steps errors 1

Expand to view the steps failures

Error signal
  • Took 0 min 0 sec . View more details here
  • Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/m-hafi return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/m-hafi : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/m-hafi : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}

:robot: GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

apmmachine avatar Feb 17 '22 14:02 apmmachine

Hi @m-hafi,

it seems the CLA is not yet signed - we'd need that before we proceed.

More importantly, we'll need tests which cover this feature and the new config should be also documented. We have a doc about the PR process here.

The idea with this feature already came up, but it was low prio: https://github.com/elastic/apm-agent-dotnet/issues/782

I'll bring this up in our planning meeting and see how we proceed - if you have time and you could invest into covering this with tests and add the docs I'm happy to review - otherwise we'll need to invest more time into this, which we did not plan short term.

gregkalapos avatar Mar 02 '22 19:03 gregkalapos

You should consider adding support for proxy credentials in addition to the URL https://learn.microsoft.com/en-us/dotnet/api/system.net.iwebproxy.credentials

bjola avatar Feb 21 '23 09:02 bjola

Closing this because we are looking to move from our internal payloadsender to https://github.com/elastic/elastic-ingest-dotnet/blob/main/src/Elastic.Ingest.Apm/README.md

This would standardize the transport configuration options for Elastic Products across the board for our .NET libraries. Including proxy support with authentication.

Mpdreamz avatar Feb 22 '23 14:02 Mpdreamz