Support 7.0

[KodrAus]

Since we don't map a lot of the Query DSL yet this should just be a matter of tweaking some bits in elastic_types and updating CI to target 6.0.

The biggest change to think about is the removing support for multiple types per index. An implication is that we could remove indices as required parameters and rely on the type name as a default. It raises a question of whether all operations, like index_create, should require a generic document type.

[mbilker]

I just tried to use this library with 6.0.0 and I got an error when indexing a document stating missing field "created", which I assume is because the created field has been removed and replaced with the operation field[1].

[1] https://www.elastic.co/guide/en/elasticsearch/reference/6.x/breaking_60_docs_changes.html

[KodrAus]

Ah thanks @mbilker! These are all localised to the responses side but are breaking changes so I'll need to roll them up into the next release. I don't have much blocking that besides a half-baked cluster sniffer so will work on 6.0 support and get that up on crates.io ASAP.

[mbilker]

Thank you very much and glad to be of help!

Luckily I am only working on a small personal project and I just rolled back to 5.6.4, but I will likely test changes for 6.x support as I have two virtual machines, one with 5.6.4 and one with 6.0.0.

[KodrAus]

Just to communicate the plan here, I'm thinking I'll cut a release of 0.21.0 with the new client features, and then focus on support for Elasticsearch 6.0 purely for 0.22.0. I think that path should be clearer for people looking to upgrade, and anyone stuck on 5.0 for now can still get the benefit of some of these new features.

[twilco]

Hey! I'm interested in seeing support for ES6. Is there anywhere I can lend a hand to help with this?

[KodrAus]

Hi @twilco!

This library's in a bit of a state where it's hard to meaningfully contribute to at the moment unfortunately. I need to get #315 polished up and merged, and then get the work-in-progress stuff off the vNext branch and onto master, then we should be in a better place to look at what else needs to be done to support Elasticsearch 6.

I've got a little time later today, so I'll try get that moving again.

[twilco]

Thanks for the update! If there's some way others can contribute once that work has been completed drop another comment 😄

[KodrAus]

Alrighty! I've cleaned up and merged all the work in progress onto master and updated the integration tests to run against Elasticsearch 6.5.

I think what we really need now is some good testing to make sure everything is looking good for 6.0 support, because the integration test coverage is a bit thin at the moment.

If folks would like to give it a go I can publish a preview on crates.io. There are some significant API changes between master and what's published at the moment.

[mwilliammyers]

So what about 7.0? haha...

There doesn't seem to be that many breaking changes that we would have to worry about...

[DevQps]

I would like to see this as well!

[KodrAus]

I've bumped our target up to 7.0, which we should "support" on master (and in the next preview) once #364 lands.

[flaper87]

@KodrAus this upcoming cut looks AWESOME and promising. Thanks a bunch for your hard work here.

Do you know if/when you're going to cut a new pre release for 0.21?

[KodrAus]

Hi @flaper87! :wave:

I was going to work in support for the scroll API first, but there’s a lot of inventory on master now that fixes real issues. So I’ll just give the docs a run through and get it up on crates.io ASAP.

[flaper87]

@KodrAus fantastic!

FWIW, I've been using master for the last three days and things seem to work for me. Looking forward to the next pre cut and to the next release! thanks again :)

[KodrAus]

Alrighty, I've published a new pre-release as 0.21.0-pre.5!

This one pushes our target version of Elasticsearch to 7.2. I've also refactored our integration tests so that they should be easier to add (there's still a lot of fiddling with async code though). So I think the only real blocker to a proper release is confidence that we support 7.x correctly and don't need to break a lot of other things.

[flaper87]

Amazing!

My current use case is simple but I can try to come up with more thorough tests for this.

Thanks again 🤙😬

[DevQps]

Thanks a lot for everything! Great work! Without you I wouldn't have been able to continue my work :)

[Bealiah-dev]

Hello,

Version field in hit struct is outdated for optimistic version control. Could you add _seq_no and _primary_term ?

Nice crate btw !

[mwilliammyers]

@Bealiah-dev those were added in 08ed5ce8a9881bc4dfe546055c4f020f33ed01d7. Both the latest pre-release version (0.21.0-pre.5) and the latest stable release (0.20.10) do not have that commit though. It will be in the next release though!

And, thanks! All the credit goes to @KodrAus & the other contributors though 😊

[Bealiah-dev]

@mwilliammyers Thanks , it's awesome.