manifold icon indicating copy to clipboard operation
manifold copied to clipboard

Do nothing if the half edge array is empty.

Open fire opened this issue 2 years ago • 6 comments

Let's see if this fixes the bug.

fire avatar Aug 03 '22 18:08 fire

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Aug 03 '22 18:08 google-cla[bot]

What bug was this fixing? Can you add a test case to demonstrate?

elalish avatar Aug 04 '22 15:08 elalish

I don't have the test case on hard, it was with an empty manifold.

fire avatar Aug 08 '22 10:08 fire

Can you please add a test so we know what problem we're fixing? You should be able to copy this one and tweak slightly: https://github.com/elalish/manifold/blob/master/test/mesh_test.cpp#L608

elalish avatar Aug 08 '22 16:08 elalish

I'm not able to work on this much because of siggraph 2022 this week.

fire avatar Aug 09 '22 16:08 fire

Got it, no prob. I'm curious, mostly :)

elalish avatar Aug 09 '22 20:08 elalish

I wasn't able to get myself to work on this. Godot Engine 4 work has been tiring.

fire avatar Aug 25 '22 00:08 fire