pyrallis icon indicating copy to clipboard operation
pyrallis copied to clipboard

Published 20 hours ago • verified publisher icon eladrich

Add option alias

Open de9uch1 opened this issue 2 years ago • 4 comments

Add option alias setting alias in metadata of dataclass fields.

de9uch1 avatar Jun 09 '22 04:06 de9uch1

https://github.com/lebrice/SimpleParsing/blob/ed8170a32e7765bd98ed42831a428f0cdb645b67/simple_parsing/helpers/fields.py#L38

lebrice avatar Jun 10 '22 03:06 lebrice

https://github.com/lebrice/SimpleParsing/blob/ed8170a32e7765bd98ed42831a428f0cdb645b67/simple_parsing/helpers/fields.py#L38

@lebrice Thank you for your comment. I've updated pyrallis.field() to be able to pass aliases like SimpleParsing.

de9uch1 avatar Jun 10 '22 10:06 de9uch1

Thanks @de9uch1 for the pull request!

We did consider supporting aliases in the past but decided that it goes against the design we are aiming for. Pyrallis currently uses a simple one-to-one mapping between the input arguments and the dataclass fields and we want to keep enforcing that.

@lebrice's SimpleParsing is indeed a great choice if you need alias support or other advanced features.

Keeping this pull request open if you want to discuss further 🙃

eladrich avatar Jun 12 '22 05:06 eladrich

Thank you for your reply, @eladrich.

OK, I understand. I think it is a great decision for a simple and consistent design.

I'll decide to create pyrallis-plus, the wrapper of Pyrallis that is added some features at the expense of simplicity.

If there is no problem, I would like to close this PR, is that OK?

de9uch1 avatar Jun 15 '22 10:06 de9uch1