pikud-haoref-api icon indicating copy to clipboard operation
pikud-haoref-api copied to clipboard

Update Deps & use lockfile v2 (npm 7) & Migrate from deprecated request package

Open emanuelb opened this issue 3 years ago • 2 comments

  1. Use newer lockfile format https://github.com/eladnava/pikud-haoref-api/blob/7dd639c5d0c672131d44687cf9107e95e519af66/package-lock.json#L4 There is newer lockfileVersion 2 (different file format) which is available & generated by npm 7: https://github.blog/2021-02-02-npm-7-is-now-generally-available/#changes-to-the-lockfile

  2. Upgrade packages https://github.com/eladnava/pikud-haoref-api/blob/7abeaa809f643434dcc9ba09a975099c2e32f07b/package.json#L20 latest version of cheerio is 1.0.0-rc.9 https://github.com/eladnava/pikud-haoref-api/blob/7abeaa809f643434dcc9ba09a975099c2e32f07b/package.json#L23 latest version of request is 2.88.2

  3. request package is deprecated and migration to another package is needed.

emanuelb avatar May 15 '21 13:05 emanuelb

Hi @emanuelb, Thanks for your suggestion. Please submit a PR with the requested changes. 👍

eladnava avatar Jun 17 '21 15:06 eladnava

I have just forked the repo and I will be replacing everything shortly.

To clarify; I will replace the request package with fetch, a built-in replacement who's API is already common-found in the JavaScript world. However, since Node.JS introduced it very late into the game, I will be adding a polyfill. Cheerio's syntax is also non-standard; we now use the way JS interfaces with DOM, so that will be switched too. Finally, lock file will be recreated, so it'll be upgraded regardless.

NightScript370 avatar Oct 09 '23 15:10 NightScript370