Elad Nava

Results 118 comments of Elad Nava

@hypesystem Isn't that 'some point' now since we are basically cleaning everything we think should be cleaned up? Or would you rather wait till the end of everything else?

Awesome! :octocat: 😄

@hypesystem How do you currently detect a topic versus a registration token passed in via the second argument?

We could instead change the interface to allow passing in an object (but the same exact object later passed into the request, e.g. `to`, `registration_ids`, or `condition`). If an array...

@hypesystem Isn't `notification_key` deprecated? Is there any reason to invest time in this?

@hypesystem Oh, cool! Seems pretty easy, we need to add a function that accepts a `sender ID`, `notification key name` and `registration tokens`, executes the following request, and returns the...

Seems like this is partially addressed via https://github.com/ToothlessGear/node-gcm/pull/319/files#diff-4ac32a78649ca5bdd8e0ba38b7006a1eR4.

It can definitely contain both `message_id` and `registration_id`. > `message_id`: String specifying a unique ID for each successfully processed message. > `registration_id`: Optional string specifying the canonical registration token for...

@hypesystem Would we provide the old keys as aliases for backward compatibility?

Cool. I definitely agree with making it possible to pass in properties the same way as with GCM (`collapse_key` for example)