ha-hpprinter icon indicating copy to clipboard operation
ha-hpprinter copied to clipboard

Fix log errors caused by BW printers #57

Open tagno25 opened this issue 4 years ago • 4 comments

This seems to have fixed #57 and still behaves correctly when data_item is None

tagno25 avatar Aug 18 '20 06:08 tagno25

@tagno25 not sure what you tried to achieve? can you pleasesend the XML examples of your printer? if you know the code is about to fall from the specific exception, why not to pre-handle it?

thanks

elad-bar avatar Oct 01 '20 20:10 elad-bar

I was trying to get rid of the massive number of errors in the logs caused by black and white only printers.

Here are the XML files for my printer. https://gist.github.com/tagno25/0b9071c6c90110282e1eec7af9fb7ca2

tagno25 avatar Oct 04 '20 22:10 tagno25

Will this ever be merged? BW-only printers still don't work to this day 😕

SaifAqqad avatar Nov 26 '20 18:11 SaifAqqad

thanks for assisting

I will get to it next weekend, I need to test it with different type of printer to make sure it will not impact them, It worked originally very similiar to that and I changed it because of issue caused from that, will get back to you

elad-bar avatar Nov 28 '20 16:11 elad-bar

not relevant

elad-bar avatar Jun 15 '24 08:06 elad-bar