BACnet icon indicating copy to clipboard operation
BACnet copied to clipboard

Update BACnetClient.cs

Open BennoMeijer opened this issue 7 years ago • 3 comments

Add a overload for the ReadRangeResponse so a bacnetBitString can be used and status flags set to false will be visable

BennoMeijer avatar Dec 19 '17 06:12 BennoMeijer

@BennoMeijer I remember the discussion we had about the trend log and bit string but is this the right way to go? First of all I would like to avoid putting class like BacnetBitString in the main API of BACnetClient. In version 2 I will simplify it and avoid using classes like this in the API as I consider them more advanced or internal components. How about we use the change from PR #11 and in ReadRangeResponse we declare how many bits are to be used, instead on using the enum value which can suggest we are using only 1 therefor ignoring the remaining false ones.

gralin avatar Dec 19 '17 23:12 gralin

Hello Gralin. I did not want to change too much, but for the status flags FirstItem, LastItem and MoreItems I also need the flags if they are false. I asked the support center for the scada software and told me that it was mandatory to have these flags. If the ReadRangeResponse is only used for the trendlog, we also could set the bits there and use a uint for the status, but i didn't want to break someone else his code

BennoMeijer avatar Dec 27 '17 13:12 BennoMeijer

@BennoMeijer I get your point and sorry for the delay, I was swamped at work. I will either merge this or suggest a change withing a week. Happy New Year by the way 😄

gralin avatar Dec 29 '17 22:12 gralin