MagicPlugin icon indicating copy to clipboard operation
MagicPlugin copied to clipboard

Wand Enchants Lore Text Duplicating

Open castozen opened this issue 2 years ago • 5 comments

Hi. When enchanting a wand the text duplicates in the lore. I have some weapons that have spells e.g on the right click and would like them to be enchantable. In the video the duplicate enchants are only viewable when item is in anvil. But if you pre-enchant in the config and the player enchants it further it is visible always. Thank you :)

https://github.com/elBukkit/MagicPlugin/assets/114535021/19590999-a08b-4833-b83f-8a207704db53

castozen avatar Jun 29 '23 20:06 castozen

Do you have a screenshot or any more detailed explanation of what you're seeing?

NathanWolf avatar Jun 29 '23 20:06 NathanWolf

apologies, I prematurely posted. I have edited the post

castozen avatar Jun 29 '23 20:06 castozen

Thank you for the reproduction steps!

I'm guessing there is some set of default flags used by configured wands to hide the vanilla enchantment lore, but it is missing when you just use /wand create

I will take a look when I can, guessing the solution will be for the wand to look at item flags and skip adding enchantment lore if the vanilla lore is not hidden.

NathanWolf avatar Jun 29 '23 20:06 NathanWolf

To add to this, I've been having problems with enchantments on wands not saving correctly, such as enchanting a wand with the /mitem add enchant. The enchantments are removed when the wand is updated (held in hand or worn.)

Other issues are that anvilling enchanted books with wands doesn't seem to work, the result in the anvil shows up but I can't remove it from the anvil. Modifiable: true and enchantable: true are both on, so I don't get why.

I can demonstrate or send over more detailed reproduction steps if needed.

I0nTech avatar Jul 10 '23 22:07 I0nTech

The lore duplication issue is fixed in the latest 10.8.10 dev build.

The /mitem commands don't really work on wands. Wands manage the properties of the item (such as enchantments) themselves, so you have to configure the wand's enchantments (usually via configs, but the /wand configure command can do it too)

In general I recommend using configs and especially the wand editor for making wands, rather than trying to make them on the fly with commands. /meditor wand will guide you through the process, it's pretty easy.

NathanWolf avatar Aug 13 '23 21:08 NathanWolf