EffectLib icon indicating copy to clipboard operation
EffectLib copied to clipboard

Published 20 hours ago • verified publisher icon elBukkit

Commits from old repo and finished 2 TODOs

Open AnonymousBluejay opened this issue 3 years ago • 4 comments

rotateVector() in VectorUtils may be a bit more optimized now documented Nautilus particle

AnonymousBluejay avatar Apr 25 '22 08:04 AnonymousBluejay

Just realized the note about moving to fork probably isn't needed here

AnonymousBluejay avatar Apr 25 '22 08:04 AnonymousBluejay

Thank you!

So regarding the TODO:

Having some strange behavior up there.. Have to look in it later. TODO

Did you se and resolve the strange behavior? I honestly don't remember at all what was going on with this.

NathanWolf avatar Apr 25 '22 14:04 NathanWolf

I'm not entirely sure where the original commented code came from, I just changed it to apply rotations in order.

AnonymousBluejay avatar Apr 25 '22 15:04 AnonymousBluejay

The original code on April 25, 2014 was: https://github.com/elBukkit/EffectLib/blob/316cba315d6ed0c62e45b31f144de2a467b83fdc/src/de/slikey/effectlib/util/VectorUtils.java#L37-L42

The experimental code and TODO were added the next day in bfb9bec2463bca2c93f25f213b14ec0ea8350e85 already commented out, so it was never implemented. Hope that helps.

PikaMug avatar Dec 28 '22 20:12 PikaMug