el-u
el-u
Missed usages of world (usually in method signatures or local variables of type MultiWorld): AutoWorld.py: - call_single - call_all - call_stage - World.\_\_init\_\_ - World.create_item.\_\_doc\_\_ BaseClasses.py: - Region.\_\_init\_\_ - Entrance.\_\_str\_\_...
I don't disagree with the import and string changes in general, but including so many unrelated changes in this already large PR unnecessarily makes it less clear to read.
> > > I have not checked this, but I think if a world writes to self.world.option_name[player], that changes spoiler output? writes to self.options[name] are not synchronized back > >...
Please revisit my feedback from #965, i.e.: - implementing connect via super connect - correct typing everywhere for addresses and target
Generating without a yaml: Error message is printed twice. Also, there seems to be a weird additional window.  Generating without a ROM: There is no indication what the actual...
I am still seing the second window, btw. It's probably this problem: https://pythonprogramming.altervista.org/tkinters-messagebox-without-the-root-window/ Might be solvable by using the existing `Utils.messagebox`.
- The actual error message is now part of the message box. - "NoneType: None" is no longer printed in the console.
> Tested this tonight, however, and I didn't get any popup windows at all, and the error traceback printed like normal, not as depicted int the screenshots others have posted....
The implementation is flawed, it tries to control what should be a `ClassVar` using `@property` getters and setters (which affect an instance attribute). Debugging reveals that - `DarkSouls3World.web.item_descriptions` contains only...