sshx icon indicating copy to clipboard operation
sshx copied to clipboard

Windows client support

Open ekzhang opened this issue 9 months ago • 2 comments

(It looks like due to a bug or some other issue on GitHub, the previous issue for Windows support is not showing up, so I'm going to make a new one.)

The sshx client is mostly cross-platform, except one file terminal.rs. To add Windows support, we would need to port terminal.rs to Windows using the ConPTY API.

ekzhang avatar Apr 28 '24 01:04 ekzhang

Hey! What's the status of this feature?

thewh1teagle avatar Jul 21 '24 20:07 thewh1teagle

You're welcome to help implement it! It's the same as before.

ekzhang avatar Jul 21 '24 21:07 ekzhang

Super looking forward to implementing it on Windows

wll8 avatar Aug 23 '24 13:08 wll8

Me too! Please give me a holler if you'd like to work on it

ekzhang avatar Aug 23 '24 16:08 ekzhang

I had some time today and am mostly caught up on emails, so I went ahead and spun up a Windows VM on AWS and made a dev environment. Such a pain to even set up SSH compared to Linux! But that's what it is, remote desktop protocol and so on.

There is a PR #99 that adds Windows support to sshx. Please test and let me know if it works for you. You can build within the branch with cargo run -p sshx. Thanks!

I'm especially interested in hearing if the shell detection is working right. Powershell doesn't seem to be launching, besides that I'm just auto-detecting for git bash and cmd right now. Anything else people use commonly / stats about this? Cygwin?

ekzhang avatar Sep 08 '24 04:09 ekzhang