Eric Zhang comments

Results 129 comments of


                                            Eric Zhang

Implement collapsible sidebar with smooth animation

Could you separate the dependency changes into a different PR? I don't really want to review a +1300 line feature PR

Implement collapsible sidebar with smooth animation

Sorry it's been several months @ntninja — I think we should have the collapsible sidebar, but the interface designer in me isn't happy with the implementation here (specifically the choice...

Feature request: Add an option to bypass loading monaco's resources from cdn

That's awesome thanks for sharing! I think I learned how to do this in another way too in the past couple months

Make WebSocket URL relative to path on which RustPad itself is served

Hm, can you give an example of where it would be served on a subpath? Is this something supported by reverse proxies / did it come up for you?

Make WebSocket URL relative to path on which RustPad itself is served

Nice, great stuff. Is there a reason you wouldn't just forward /rustpad/:path to localhost:3000/:path?

Make WebSocket URL relative to path on which RustPad itself is served

There are not two separate servers, intended deployment method is just one server for API routes and static files. That's how the Dockerfile works!

Make WebSocket URL relative to path on which RustPad itself is served

> server static files separately since that is how all server software I know (which is mostly Python) works This isn't how the Jupyter server works, for instance. No worries...

Make WebSocket URL relative to path on which RustPad itself is served

I think this makes sense, thank you!

Make RustPad just-enough compatible with EtherPad URLs

Interesting, I like the idea! Down to merge this if the CI works.

Make RustPad just-enough compatible with EtherPad URLs

Sorry it's been a few months @ntninja — I reevaluated my priorities and I don't think I can merge this at this time. Apologies. You might need to fork :(