Eric Zhang

Results 78 comments of Eric Zhang

Apologies for the delay, but I found some time to work on this. Just filed #3133, which should fix the issue - let me know how it looks!

Unfortunately not. This dual-stack use used to be supported, but then it turns out that it doesn't work on [Windows](https://github.com/ekzhang/bore/pull/35).

@valohai — I just updated our fork to use `get_upstream_url_with_query` in the WebSocket proxy handler instead of parsing the query parameters into a multidict. (Also we're not using `asgiproxy` anymore...

Yeah, good point, I've had issues in the past re: key signatures as well. It seems like Music21 handles this somewhat inconsistently. I'll try to take a look.

Ah, I agree that seems a little awkward. Thanks for the expert feedback. I think large jumps (of > 7 semitones) in the bass are penalized, but maybe by not...

Hi @Tronic, I updated the constructor to decode bytes arguments to str. It is a bit more verbose but works without disabling the type-checker on that line now. I also...

> if not barring minor cleanup (e.g. removal of "utf8" argument on decode, perhaps some restructuring). Thanks for reviewing so quickly! I followed the pattern of the existing code to...

Yeah, can add those options to take the TLS chain and keypair as files. Focus right now isn't on self-hosting though. This is not supported, and there are no instructions...