Empty moods can exist

[bburky]

Steps to reproduce

1. Tap any group.
2. Tap the create new mood button.
3. Save the mood. (Don't add any channels or colors.)
4. Tap the newly created unnamed mood to play it.

Actual results

The app crashes with an IllegalStateException in PlayingMood.

Expected results

Users probably shouldn't be able to create completely empty moods.

System configuration

• LampShade 3.0.1
• Android 4.4.4
  CyanogenMod 11.0-XNPH44S
• OnePlus A0001, phone

[bburky]

This is arguably a duplicate of #77, but this crash is triggered by a different sequence of actions. The crashing code is possibly the same.

[ekux44]

Potentially also a duplicate of #69

[ekux44]

I propose as best practice titling issues with the crashing exception to make it easier to manage crash reports / prevent duplicates

[bburky]

This is only an issue because github doesn't have arbitrary fields in the bug tracker.

You really want 100 issues all called NullPointerException?

And what do I title issues for non-crashing bugs?

I can do that though if that's what you want.

[bburky]

That said, as long as the exception is mentioned in the text of the issue it's searchable. Which means, actually search before making issues.

But there is still a question whether you want multiple issues for the same crash triggered in different ways. And you never really know how the user triggered the crash, unless they actually write a good bug report.

[ekux44]

In the past month, Google Play has collected 17 'unique' crashes, but some of them have already been fixed in newer versions of LampShade and others are duplicates of open bugs that merely look different due to line-number changes. So managing duplicates and checking that 'new' bugs aren't existing bugs that were marked closed is a priority.

[ekux44]

Many crash reports come through Google Play without enough data to justify a title of anything other than the crashing exception, so at least some bugs will be titled that way. Additionally, I propose that crashing bugs should be one issue opened per unique crash type. If there's unexpected behavior that also happens to crash (such as empty moods which shouldn't exist regardless of the crash), a separate non-crashing issue could be opened as well.

[ekux44]

With f4b4f7d7de8b15be39bde3752429688487a9241b this no longer crashes, so it's now just an issue of unexpected behavior that empty moods can exist