eksctl
eksctl copied to clipboard
eksctl-io
[Feature] Add hpc7g.16xlarge, hpc7g.8xlarge and hpc7g.4xlarge to the list of supported instances when setting efaEnabled: true
We just announced hpc7g instances in general availability and we need eksctl workflow when setting efaEnabled: true to support hpc7g.16xlarge, hpc7g.8xlarge and hpc7g.4xlarge in the EFA plugin.
https://github.com/weaveworks/eksctl/blob/943de8393a2a30a9ba40d7850e63f5d7c17c0e3a/pkg/addons/assets/efa-device-plugin.yaml#L36-L152
https://aws.amazon.com/about-aws/whats-new/2023/06/amazon-ec2-hpc7g-instances/
Note that the pull request mentioned was marked stale and closed. I am going to look into using Terraform/Tofu instead.
Note that the pull request mentioned was marked stale and closed. I am going to look into using Terraform/Tofu instead.
@vsoch, I have reopened the PR.
Thank you! :raised_hands: I'm about to go to bed, but please let me know what is needed for review. The other show stopper for us (meaning the functionality absolutely did not work given the bug) was https://github.com/eksctl-io/eksctl/pull/6870 and the daemonSet with runAsNonRoot to true. But likely we can compromise on that one and just use the helm template. But then arguably the efaEnabled should be removed here.
But overall, thank you so much for reopening this @cPu1 - I am hopeful we can get these issues resolved together, and able and willing to help however I can.
hey folks! My PR to add this support was again closed. Can we get this added soon, or do we need to continue to use custom bulids?