style(get): Adjust the command line parameters to be consistent

[ysicing]

Adjust the command line parameters to be consistent

Signed-off-by: ysicing [email protected]

Description

Checklist

• [ ] Added tests that cover your change (if possible)
• [ ] Added/modified documentation as required (such as the README.md, or the userdocs directory)
• [x] Manually tested
• [ ] Made sure the title of the PR is a good description that can go into the release notes
• [x] (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! :exploding_head:

• [ ] Backfilled missing tests for code in same general area :tada:
• [ ] Refactored something and made the world a better place :star2:

[cPu1]

@ysicing, apologies for the delay. I'm occupied with other tasks and will need some time to review the new changes.

[Himangini]

There's still at least one command https://github.com/weaveworks/eksctl/blob/main/pkg/ctl/utils/describe_addon_versions.go#L32 that isn't using cmdutils.AddClusterFlag.

@ysicing can you add changes for this as well, we'll get the PR merged after the changes are added. 👍🏻

[ysicing]

@Himangini @cPu1 PTAL

[ysicing]

@Himangini add test code ?

[Himangini]

@Himangini add test code ?

No, add some description of how you manually tested this.

[ysicing]

new version flags cluster has short command c

# old create iamserviceaccount
eksctl  create iamserviceaccount -h
Create an iamserviceaccount - AWS IAM role bound to a Kubernetes service account

Usage: eksctl create iamserviceaccount [flags]

General flags:
      --cluster string                      name of the EKS cluster to add the iamserviceaccount to

# new create iamserviceaccount
eksctl create iamserviceaccount -h
Create an iamserviceaccount - AWS IAM role bound to a Kubernetes service account

Usage: eksctl create iamserviceaccount [flags]

General flags:
  -c, --cluster string                      EKS cluster name

# old delete nodegroup
ekctl delete nodegroup -h
Delete a nodegroup

Usage: eksctl delete nodegroup [flags]

Aliases: nodegroup, ng

General flags:
      --cluster string                      EKS cluster name

# new delete nodegroup

eksctl delete nodegroup -h
Delete a nodegroup

Usage: eksctl delete nodegroup [flags]

Aliases: nodegroup, ng

General flags:
  -c, --cluster string                      EKS cluster name