eksctl icon indicating copy to clipboard operation
eksctl copied to clipboard

[Task] Refactor task.go

Open Himangini opened this issue 3 years ago • 5 comments

Description

This ticket is to refactor the functionality mentioned below and here

What can stay and what should be moved

pkg/eks contains:

$ ll
api.go
client.go
compatibility.go
eks.go
fargate.go
logging_retryer.go
nodegroup.go
nodegroup_service.go
tasks.go
update.go

Lets take a look at each file and see whats in it

....

task.go

:panic: tasks shouldn't be here. Move to own packages/inside pkg/action/<resource> where appropriate

Himangini avatar Jul 04 '22 15:07 Himangini

Hi @Himangini I would like to work on this issue. As per my understanding we need to remove tasks.go file and place the functions present inside it into tasks.go under appropriate pkg/action/. i.e pkg/action/addon

vipinachar avatar Aug 07 '23 12:08 vipinachar

@vipinachar thanks for showing interest in eksctl ✨ Pls feel free to pick this up, and open PRs. We're happy to review your contribution.

Himangini avatar Aug 07 '23 13:08 Himangini

@Himangini Can you please check if I am headed in the right direction with my changes.

vipinachar avatar Aug 07 '23 16:08 vipinachar

@Himangini Can you please check if I am headed in the right direction with my changes.

@vipinachar pls see the review comment https://github.com/eksctl-io/eksctl/pull/6930#issuecomment-1676747852

Himangini avatar Aug 29 '23 15:08 Himangini