eksctl icon indicating copy to clipboard operation
eksctl copied to clipboard

Deprecated apiVersion used for MutatingWebhookConfiguration and CertificateSigningRequest

Open nluckenbill opened this issue 4 years ago • 12 comments

Hello, when creating a new admission controller, eksctl prints out the following warnings:

warnings.go:67] certificates.k8s.io/v1beta1 CertificateSigningRequest is deprecated in v1.19+, unavailable in v1.22+; use certificates.k8s.io/v1 CertificateSigningRequest
warnings.go:67] admissionregistration.k8s.io/v1beta1 MutatingWebhookConfiguration is deprecated in v1.16+, unavailable in v1.22+; use admissionregistration.k8s.io/v1 MutatingWebhookConfiguration

This can be reproduced following the instructions here: https://docs.aws.amazon.com/eks/latest/userguide/windows-support.html#enable-windows-support

VERSIONS

Admin:~/environment $ eksctl version
0.53.0
Admin:~/environment $ kubectl version
Client Version: version.Info{Major:"1", Minor:"19+", GitVersion:"v1.19.6-eks-49a6c0", GitCommit:"49a6c0bf091506e7bafcdb1b142351b69363355a", GitTreeState:"clean", BuildDate:"2020-12-23T22:13:28Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"19+", GitVersion:"v1.19.8-eks-96780e", GitCommit:"96780e1b30acbf0a52c38b6030d7853e575bcdf3", GitTreeState:"clean", BuildDate:"2021-03-10T21:32:29Z", GoVersion:"go1.15.8", Compiler:"gc", Platform:"linux/amd64"}

nluckenbill avatar Jun 17 '21 18:06 nluckenbill

Thanks for the heads-up, we'll work on this soon.

cPu1 avatar Jun 21 '21 08:06 cPu1

@cPu1 are you actively writing this at the moment? If not can you un-assign and throw it back into the pool?

Callisto13 avatar Aug 06 '21 12:08 Callisto13

In addition to switching to the stable API versions, it will be best to stay away from the Legacy K8s signer, and instead use cert-manager or similar tool to issue the certificate for the admission webhook.

awsitcloudpro avatar Aug 17 '21 15:08 awsitcloudpro

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Sep 17 '21 01:09 github-actions[bot]

@cPu1 do you know if we are still blocked upstream on this?

Callisto13 avatar Sep 17 '21 08:09 Callisto13

@cPu1 do you know if we are still blocked upstream on this?

We're blocked upstream on CertificateSigningRequest, but not on MutatingWebhookConfiguration. We should be able to migrate to admissionregistration.k8s.io/v1.

cPu1 avatar Sep 17 '21 10:09 cPu1

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Oct 18 '21 01:10 github-actions[bot]

We have a merged PR that we had to revert temporarily, that will remove the need for installing the VPC controller in order to run Windows workloads, making this issue obsolete. We'll close this issue when we re-merge that PR back.

cPu1 avatar Oct 18 '21 06:10 cPu1

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Nov 18 '21 01:11 github-actions[bot]

Not stale, this is blocked on AWS.

cPu1 avatar Nov 18 '21 07:11 cPu1

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] avatar Dec 19 '21 01:12 github-actions[bot]

We have a merged PR that we had to revert temporarily, that will remove the need for installing the VPC controller in order to run Windows workloads, making this issue obsolete. We'll close this issue when we re-merge that PR back.

@cPu1 The PR you mentioned is merged, can we close this issue, or is this still blocked upstream?

Himangini avatar May 18 '22 16:05 Himangini

This is obsoleted by https://github.com/eksctl-io/eksctl/pull/4338.

cPu1 avatar Oct 03 '23 07:10 cPu1