aws-nuke
aws-nuke copied to clipboard
feat(resource): added route53 resolver firewall rule groups, domain lists, query log configs
Second try with commit comments tweaked to pass commit linting
Things to note:
- Uses V2 of the AWS Go SDK since V1 didn't support FirewallThreatProtectionId which is needed to remove Firewall Rule Group rules that have that set.
- Interfaces are nice for testing, but using V2 lost the interfaces provided in V1, so I manually created one, and used that in a pattern suggested in stackoverflow for injecting service interfaces.
- Switched mocks to the uber version since gomock appears to be EOL'd
- Disabling mutation protection on VPC associations isn't in this change. I may submit a new PR for that later.
This is the first significant thing I've done in golang, so hopefully it's not too hacked.