Daniel
Daniel
The external tests actually all passed - here's the relevant part of the benchmarks from using ``scripts/externalTests/benchmark_diff.py`` between the ``summarized-benchmarks-develop-b80f4baa.json`` and ``summarized-benchmarks.json`` artifacts of the ``c_ext_benchmarks`` CI run: ### `ir-optimize-evm+yul`...
For reference the gas differences of the latest version: (The perpetual pools regression is probably merely due to non-determinism) ### `ir-no-optimize` | project | bytecode_size | deployment_gas | method_gas |...
Just getting back to this now - the last runtime gas diff actually doesn't look too bad - I'm a bit surprised about the code size increase that remains. Out...
Yeah - I'd be alright with starting with that approach. On the other hand, I'm still actually a bit surprised by the changes in bytecode size. I'm a bit swamped...
Ah, nice, I hadn't realized, I'll try to have a look at the latest version of https://github.com/ethereum/solidity/pull/12978 then! And yeah, ``codesize`` may seem weird, but it's actually used specially by...
Yep, looks like something off with the compiler injection: https://app.circleci.com/pipelines/github/ethereum/solidity/25600/workflows/db515520-4bf7-48e8-9b72-1961f8ffe511/jobs/1129043
Looks like the repo now contains a typescript ``hardhat.config.ts`` that overwrites the ``.js`` file... proper way to fix this would probably be to have that supported in ``force_hardhat_compiler_binary`` and ``force_hardhat_compiler_settings``...
I did that, and it failed, when I tried, but I can have another look :-).
``` Assertion failed. Stack trace: test/externalTests/common.sh:335 in function force_hardhat_compiler_settings() [[ $config_var_name != "" ]] || assertFail test/externalTests/ens.sh:65 in function ens_test() force_hardhat_compiler_settings "$config_file" "$(first_word "$SELECTED_PRESETS")" test/externalTests/common.sh:556 in function external_test() $main_fn test/externalTests/ens.sh:93...
This is the case triggering the bug: https://gist.github.com/ekpyron/faca83a32a77ba4393f88cace7e79663