fetchFalcorDeps shouldn't be an instance method

[limscoder]

fetchFalcorDeps should be a stand-alone function similar to mapStateToProps so the component doesn't need to know anything about falcor.

reduxFalcor(fetchFalcorDeps, component)

[blizzardzheng]

i agree , when i just use for arrow pure function like this const CounterApp = (props) => { const { counter, actions } = props; return ( <div> <Counter counter={counter} {...actions} /> </div> ); };

and it will throw error that Cannot read property 'fetchFalcorDeps' of null the component need not to know anything about falcor.

[blizzardzheng]

waiting for resolve

[ekosz]

@limscoder @blizzardzheng Totally agree. Unfortunately I don't have time to maintain this project anymore. But happy to review PRs for this!

[pickhardt]

Instead of reduxFalcor(fetchFalcorDeps, component) I propose reduxFalcor(component, fetchFalcorDeps) for backwards compatibility. The second param fetchFalcorDeps would be optional, like this:

  fetchFalcorDeps = fetchFalcorDeps || wrappedInstance.fetchFalcorDeps;