Ewoud Kohl van Wijngaarden

Results 290 issues of Ewoud Kohl van Wijngaarden

I've split https://github.com/theforeman/foreman/pull/9871 up and introduced an alternative (which I don't know whether it works) for the `method_missing` implementation. And https://projects.theforeman.org/issues/35300 was incomplete with fixing kwargs. There are probably more...

Not yet reviewed

By default this derives the firmware type from the PXE loader, just like VMware does. It does not yet implement secure boot. Depends on https://github.com/fog/fog-libvirt/pull/134 to be released. Currently only...

Not yet reviewed

Since fog-libvirt 0.12.0 the default CPU model was some abstract type with a low compatibility level. Since 0.12.0 it defaults to CPU passthrough, as recommended by qemu if live migration...

Not yet reviewed

It's invalid to do translations during startup, such as in models or in controllers. You should always use `N_()` (see https://projects.theforeman.org/projects/foreman/wiki/Translating#Extracting-strings). This is because when it's running you actually don't...

Needs re-review

In the release notes we like to credit people based on the git log, but regularly people use multiple names. Git has a [mailmap feature](https://git-scm.com/docs/gitmailmap) which allows mapping it back...

Not yet reviewed

This implements a rake task orchestration:tftp:prune to prune old files. The actual pruning logic is implemented on the Smart Proxy where Foreman only specified the age (token_duration * 60). I...

Not yet reviewed

Prior to this change there was no way to explicitly indicate the origin of a report and it used scanners to determine the origin. This is expensive because it relies...

Not yet reviewed

I didn't test this PR, but it's here to demonstrate how to make tests pass on https://github.com/theforeman/foreman/pull/9745.

Not yet reviewed
Templates

The [sysusers.d format](https://www.freedesktop.org/software/systemd/man/sysusers.d.html) describes the user and group which should exist. This allows admins to introspect which users should exist. In the future it can also make packaging easier because...

Not yet reviewed