gocache icon indicating copy to clipboard operation
gocache copied to clipboard

Redis Get silently returns an empty []byte for stored []byte values

Open butaca opened this issue 1 year ago • 2 comments

The issue is similar to https://github.com/eko/gocache/issues/166 but for Redis with []byte values. When getting a []byte value the cache returns an empty []byte without an error. This is because the Redis implementation always returns strings and fails when trying to convert the value to string. Since it silently fails, it was difficult to debug.

Steps for Reproduction

  1. Set up a cache manager with a Redis store:
redisStore := redis_store.NewRedis(redis.NewClient(&redis.Options{
	Addr: "127.0.0.1:6379",
}))
cacheManager := cache.New[[]byte](redisStore)
  1. Set a []byte value
value := []byte{1, 2, 3, 4}
err := cacheManager.Set(ctx, "key", value, store.WithExpiration(15*time.Second))
if err != nil {
	panic(err)
}
  1. Get the value
cachedValue, err := cacheManager.Get(ctx, "key")
if err != nil {
	panic(err)
}
  1. Check how the returned value has len = 0
fmt.Printf("cached value len: %v\n", len(cachedValue))

Expected behavior: The returned value is the stored []byte not and empty value

Actual behavior: It silently returns an empty []byte instead of the stored value

Platforms: macOS and dockerized Linux from scratch

Versions: gocache v4.1.3 go 1.21 Redis store v4.2.0 Redis client v9.0.5 Redis server 7.0.12

butaca avatar Aug 27 '23 19:08 butaca

@eko ~~Maybe we can add a Mashaler and Unmashaler to the cache and allow users to choose whether to use them or not? This will solve the problem of this type mismatch.~~

update: The Marshaler package has implemented encapsulation logic for cached data.

luoxiaohei avatar Aug 30 '23 05:08 luoxiaohei

related https://github.com/eko/gocache/issues/197

claudiunicolaa avatar May 31 '24 19:05 claudiunicolaa