Emil Knabe

Results 314 comments of Emil Knabe

Please see here: https://github.com/esmini/esmini/blob/master/docs/BuildInstructions.md#in-brief Note: You need to have cmake installed (in addition to Visual Studio). Open a terminal, e.g. PowerShell or GIT bash. Then just follow follow the instruction,...

Did you have a chance to try the above? Let us know if it works or not. And if you think it's relevant please include error message from the unsuccessful...

Ah, I understand the question. I don't know to be honest. It would be very interesting to build with MinGW. But I haven't tried and it would probably require some...

Yes, you're right. The scenario story should not stop on the completion of its acts. And yes, a fix for this would be welcome (e.g. by a PR). 👍 BTW,...

Indeed. Good finding, thanks! Silly bug fixed by commit fc8e666e0f277a1733b81c6ae3076e1357e2fa57. Will be included in next release.

This sounds like a good idea. However, to my understanding it is similar to the already existing callback: [SE_RegisterEventCallback](https://github.com/esmini/esmini/blob/8be51cc09fd44af3dcef3e3dcc7dbffa18dfbca5/EnvironmentSimulator/Libraries/esminiLib/esminiLib.hpp#L849) - which was kindly added by @cfschaller in PR #249. To...

I agree. After looking closer I also see that only events are considered. So yes, I think it makes sense to add your proposed functionality. Regarding timestamp. You can skip...

Added [a test case](https://github.com/esmini/esmini/blob/ecde4f2a08432ccd8c8d13d53312e6a67aa959dd/EnvironmentSimulator/Unittest/ScenarioEngineDll_test.cpp#L3356) by commit [ecde4f2](https://github.com/esmini/esmini/commit/ecde4f2a08432ccd8c8d13d53312e6a67aa959dd) to 1: avoid regression of the feature and 2: to show how it works @cfschaller FYI: This feature has been merged. It's similar...

@cfschaller That sounds like a perfect plan!