Erik Kluzek

Use shr_mpi consistently throughout CTSM rather than native MPI

1

Overall we use shr_mpi_mod.F90 from cesm_share in CTSM. There are some places that we use bare MPI and the code would be cleaner if we used shr_mpi_mod.F90 exclusively rather than...

@glemieux noticed that photosynthesis was changed in the namelist for FATES simulations, but since FATES has it's own photosynthesis this setting doesn't matter. So we should remove default settings for...

Move guts of buildlib/buildnml to own python/ctsm module

1

This also should be coordinated with some work that Mike Levy is doing in CESM to have automatic checking of python modules with pylint. So some of this should happen...

Add option to write out variable names before history write to catch problems in the write

2

We sometimes have problems like #1545 where the model fails writing history variables. It would be easier to identify which fields fail if there was a write to the log...

The BGC variables: croot_prof_patch, froot_prof_patch, leaf_prof_patch, and stem_prof_patch have to be allocated to the full size for FATES, because they are passed to fire interfaces, but to ensure they are...

In #796 we deprecated Dynamic Vegetation mode and required it's use only with the ignore-warnings buildnml option. Since, BGCDV has NOT be scientifically maintained or tested in long simulations and...

Start using a FORTRAN formatter for our code and remove the vertical alignment

1

In #2144 we decided to stop adding vertical alignment in our code. With that we should remove all of the current vertical alignment in the code. But, we want to...

This is maybe technically not a bug, because it's working as it's designed. But, it has caused many people to take a long time debugging without a solution, until we...

Excess ice testing: cold-start both on and off, and finidat (without excess ice) and streams on

4

When excess ice is turned on by default for clm6_0 the main use of excess ice streams will be for cold-start cases. Hence, it makes sense to me that the...

ndep_nflds needs to be set by CAM/WACCM when ndep is provided so CTSM uses the ndep from CAM

2

### What happened? in current CLM: ctsm5_3_030, ndep_nflds needs to be set by CAM so that CTSM will use the ndep sent by it -- rather than the ndep it...