gitamp icon indicating copy to clipboard operation
gitamp copied to clipboard

Todo for stable

Open PeeHaa opened this issue 3 years ago • 1 comments

  • [x] Do we really need auryn? Or is it easier to just build the deps ourselves as we do not have a deep stack?
  • [x] We need to allow users to have the server listen on several ips/ports (an exampleis both ipv4 and ipv6 support)
  • [x] Abstract the server away in its own class
  • [x] Maybe abstract the special repositories to a dedicated class instead of repeating it (maybe even make it a config?)
  • [x] Change new Type(1), etc to not make use of magic numbers
  • [x] Make exception extend the base project exception instead of the global \Exception
  • [x] Instead of asking for a concrete HttpClient class maybe ask for an interface instead?
  • [x] Everything that returns a \Generator right now should return a Promise
  • [x] https://github.com/ekinhbayar/gitamp/pull/46/commits/2f48b31f38b8289054e91916ab0b9a390d1a7443#diff-1b3db3c3ba01baa1e657a2965f6771a6R30 should not be nullable, but instead be an empty results
  • [x] ~~Instead ofusing the onclose on the client (https://github.com/ekinhbayar/gitamp/pull/46/commits/2f48b31f38b8289054e91916ab0b9a390d1a7443#diff-1b3db3c3ba01baa1e657a2965f6771a6R52) we can just log the disconnect after this loop https://github.com/ekinhbayar/gitamp/pull/46/commits/2f48b31f38b8289054e91916ab0b9a390d1a7443#diff-1b3db3c3ba01baa1e657a2965f6771a6R77~~
    • No we do not, currently the websocket server does not handle disconnects correctly
  • [x] Test with lowest deps
  • [x] Test with highest deps
  • [x] Test with php 8 if travis made a working image yet
  • [x] Set up phpcs

PeeHaa avatar Sep 08 '20 23:09 PeeHaa