Håkan Sidenvall
Håkan Sidenvall
I noticed we have `IsControlPressed(Inputs input);` should there be a `IsControlReleased(Inputs input);` for the inverse edge? Or is this reflecting if actuated?
Regarding previous discussion of "Connected" vs "Present" based off previous APIs I have worked with I would suggest to stick to defining something like: Connected - Is a specific device...
Based on previous comments it sounds like the intention with the enum is to be applicable to this API surface only? If not to me it looks like an oppertunity...
It seems like the mouse accessors are different from the other accessors but there is still a concept of a collection of mice? I noticed the reply to Lyndon about...
What benefit do you see from having GamepadSlot an enum? It seems like an unsigned would do just fine for the "instance" use-case?
Review meeting: Discussed alternatives to enum Inputs: - if structs could be an alternative - type safety in relation enum Inputs. `public bool Input.IsControlPressed(GamepadButton button); ` vs `public struct bool...
Review meeting: Discussed why we have `mousePresent`, inherited from existing API. Should we consider calling this "pointer" to not let user assume this is a mouse. If user is developing...
Team discussion notes on last iteration of proposal (comment above): **Key concepts:** - User sees device specific enums, e.g. KeyboardButton, MouseButton etc - IsPressed accepts specific enum via overlaps supported...
Thanks for your contribution. We have filed an internal ticket on improving the API and settings for TouchSimulation to prevent surprising behavior related to enabling/disabling programmatically or via settings. Hence...
PR referenced by @chris-massie https://github.com/Unity-Technologies/InputSystem/pull/1594 have been merged so closing this PR since that is obsolete now.