jShowOff icon indicating copy to clipboard operation
jShowOff copied to clipboard

Fade Effect Broken on Newer jQuery

Open sy6502a opened this issue 11 years ago • 3 comments

When using this plugin with newer versions of jQuery like 1.9, the fade effect option will stop the rotation of the images on the last image.

It took me quite a while to figure this out. Hopefully the code can be updated, or even the main page changed from required files (1.3+) to (1.3-1.8) or something. But otherwise to the author, great plugin, thanks for sharing!

It turns out that "$.browser.msie" is removed in jQuery 1.9 and later.

I'm no jQuery expert, but here are 2 solutions to this issue that worked for me.

Add the migration plugin to your script that brings back the functionality : http://code.jquery.com/jquery-migrate-1.2.1.js

Or replace in jShowOff.js:

$.browser.msie

with

navigator.userAgent.match(/msie/i)

sy6502a avatar Aug 14 '13 17:08 sy6502a

Worked like a champ. Need to replace it in the .min file too. You saved me a TON of time.

Thanks!!!

ericnims avatar Aug 23 '13 17:08 ericnims

Noice! Thanks for this!

ibprogrammin avatar Nov 08 '13 18:11 ibprogrammin

The navigator.userAgent.match(/msie/i) fix worked for me. thx!

timriker avatar Aug 26 '14 22:08 timriker