jShowOff icon indicating copy to clipboard operation
jShowOff copied to clipboard

Numeric links don't work under jquery 1.6.

Open hdaniel opened this issue 14 years ago • 9 comments

The links show up as "undefined". Work around is to manually set the title.

hdaniel avatar Jun 21 '11 19:06 hdaniel

I've encountered the same Problem. I will be looking for a solution. If you have already found a solution then please respond to this comment.

karloscarweber avatar Jul 20 '11 22:07 karloscarweber

change line 231 of jquery.jshowoff.js from :

var linktext = $(this).attr('title') != '' ? $(this).attr('title') : i+1;

to:

var linktext = $(this).prop('title') != '' ? $(this).prop('title') : i+1;

if you want to modify your minified version then you'll need to use find and replace. .attr is only mentioned four times in the plugin so it shouldn't be hard to find. change the latter couple to .prop.

Respond if this doesn't solve the issue.

karloscarweber avatar Jul 20 '11 23:07 karloscarweber

That did the trick, awesome!

justincavery avatar Aug 04 '11 02:08 justincavery

Perfect, thank you.

estevesklein avatar Jul 10 '12 21:07 estevesklein

Works! Perfect solution. Thanks @karloscarweber!

sanntu avatar Jul 13 '12 19:07 sanntu

Thanks @karloscarweber! http://www.universemagic.com

mki80 avatar Oct 21 '12 12:10 mki80

wow! Thank you so much!. This helped me a lot =)

sulaya86 avatar May 21 '13 17:05 sulaya86

Thanks karloscarweber. That fixed what I was having trouble with.

LifeSteala avatar Jun 17 '13 05:06 LifeSteala

Perfect thanks !! (Y)

cocotopia avatar Dec 06 '13 18:12 cocotopia