nodeenv icon indicating copy to clipboard operation
nodeenv copied to clipboard

Replace additional use of `which(1)` with `shutil.which()`

Open mgorny opened this issue 1 year ago • 4 comments

Replace the remaining use of external which(1) tool with shutil.which() from the standard Python library, finally removing the dependency on a third party package.

This is a followup to 1024f4f64ceabd612b4df9a0b9dbe2691b2f5f9d.

mgorny avatar May 31 '24 16:05 mgorny

Hey! Thanks for the patch! Could you, please, add some test?

ekalinin avatar Aug 25 '24 10:08 ekalinin

What kind of test?

mgorny avatar Aug 25 '24 11:08 mgorny

Unit test.

ekalinin avatar Aug 25 '24 11:08 ekalinin

install_activate is already covered by tests. I fail to see what I could test differently there.

mgorny avatar Aug 25 '24 11:08 mgorny