Eric Kafe
Eric Kafe
Thanks @cclauss and @purificant!
In the past, several issues have reported zipfile failures, and sometimes mentioned [the following error](https://github.com/nltk/nltk/issues/2992#issuecomment-1552086632): > TypeError: expected str, bytes or os.PathLike object, not ZipFilePathPointer Since this PR specifically solves...
The latest commits expand the scope of this PR to allow running all the unit tests under _nltk/test/unit_ from zipped packages. Thus, instead of 4 out of 5 nltk_data packages,...
LGTM: **Status / Summary** This PR introduces `open_datafile` as a common helper around `PathPointer.open`, and updates various callers and tests to use it. As a result: - Many models and...
Let's try this now, so it is available to the forthcoming security PRs.
This works on Linux, but raises completely different errors on macOS vs. Windows, and will require several fixes in other files for CI to pass.
@HyperPS, your recent commits don't seem to change anything to the CI failures. The logs show what needs to be addressed: a Mac problem in _.github/workflows/ci.yml_, with hashFiles('tools/github_actions/third-party.sh') , while...
This needs considerable refactoring, and is far from ready for review. I suggest marking it as draft instead.
@HyperPS, your fix is mergeable as it is. However, it would be relevant to hear about your eventual plans to also address pre-existing symlinks. Also, will there be a need...
Thanks @HyperPS! Please note the CI failures: apparently, you would just need to keep these original lines: ``` def _unzip_iter(filename, root, verbose=True): if verbose: sys.stdout.write("Unzipping %s" % os.path.split(filename)[1]) sys.stdout.flush() #...