typed_struct icon indicating copy to clipboard operation
typed_struct copied to clipboard

Published 20 hours ago • verified publisher icon ejpcmac

feat: add type parameters

Open fahchen opened this issue 1 year ago • 4 comments

related pr https://github.com/ejpcmac/typed_struct/pull/28

fahchen avatar Sep 19 '22 03:09 fahchen

Hello, thank you for your PR! @flupke, I’ve also read your comments on the other PR, sorry that both of you have worked on the same subject.

I’m still quite loaded on non-OSS personal duties this week, and not available this week-end, but I will review it next week, along with other pending PRs.

As stated in the CONTRIBUTING.md, work should be based and merged back to develop. Could you then just rebase your PR on top of develop and re-target it to develop? It will run the CI as well, as it is enabled only for PRs to develop.

Note that I have disabled Elixir 1.14 from the CI as of now, as there is a bug in Elixir 1.14.0 breaking typed_struct, which will be fixed in the next Elixir release.

ejpcmac avatar Sep 23 '22 11:09 ejpcmac

@flupke Thanks for your suggestions that makes sense.

@ejpcmac Thanks for your reply, and I’ve updated the PR according to the CONTRIBUTING.

fahchen avatar Sep 24 '22 05:09 fahchen

This is an awesome package that saves me a ton of boilerplate. Thanks @ejpcmac! Unfortunately, I really need parameterized types. Is this still being considered, or am I better off forking/creating a plugin? Thanks!

sethcalebweeks avatar Dec 28 '23 05:12 sethcalebweeks