spr icon indicating copy to clipboard operation
spr copied to clipboard

Published 20 hours ago • verified publisher icon ejoffe

Support reading github token from system encrypted storage

Open phanhuyn opened this issue 1 year ago • 0 comments

Why

  • Currently, spr retrieves the github token from plaintext config: https://github.com/ejoffe/spr/blob/66dd2f0dab7369ab227b01aa76eed237ab3d3b60/github/githubclient/client.go#L80
  • Since git cli 2.24.0, gh auth login supports --secure-storage by default, and stores the token in system encrypted storage.
  • This causes spr to fail with No GitHub OAuth token found!

What

  • Support retrieving token from system encrypted storage

phanhuyn avatar Dec 12 '23 03:12 phanhuyn